Zend: refactor fast ZPP to only use zend_expected_type - #23105
Draft
Girgias wants to merge 4 commits into
Draft
Conversation
This effectively mimics part of what Fast ZPP does and allows us to re-use the fast ZPP error APIs
And stop throwing the exceptions directly, fixing quiet mode handling at the same time.
…l handling anyway
Removing the usage of zpp_error and allowing 'slow' ZPP to reuse the error logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the usage of zpp_error and allowing 'slow' ZPP to reuse the error logic.
Based on #23052 and #23104